Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' sub-command ...................................................................... Patch Set 5: (1 comment) looks good overall http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/3/src/kudu/tools/tool_action_tablet.cc@254 PS3, Line 254: bool has_promote = !GetCommandLineFlagInfoOrDie("attribute_promote").is_default; > You and Alexey would have a better idea than me. As I recall when I asked A In the future we will likely add attributes. Will we always try to prevent the user from setting attribute combinations that are not helpful? What if we wanted to do it to hack around something in the future? -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 19 Jun 2018 23:08:09 +0000 Gerrit-HasComments: Yes
