Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' sub-command ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/10536/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10536/6//COMMIT_MSG@7 PS6, Line 7: sub-command > Nit: command Done http://gerrit.cloudera.org:8080/#/c/10536/6//COMMIT_MSG@9 PS6, Line 9: Introduced 'kudu tablet set_attributes' sub-command for the kudu CLI > Do we need a corresponding get_attributes command in order to figure out wh Hm...I thought these attributes were exposed in ksck but don't see any code for it. I think that's how they should be exposed so that will have to be a follow-up. If it were a separate tool it'd probably be best done as part of a tool that dumps a replica's full consensus info. http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/kudu-admin-test.cc@1498 PS6, Line 1498: const string replace_flag = "--attribute_replace"; : const string promote_flag = "--attribute_promote"; > Nit: could be const char*, and should be named kFooFlag since they're const Done http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/kudu-admin-test.cc@1500 PS6, Line 1500: const MonoDelta timeout = MonoDelta::FromSeconds(10); > Nit: kTimeout Done http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/kudu-admin-test.cc@1582 PS6, Line 1582: string err; > We're not using err in this call; could we use a different overload of RunK Done http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/kudu-admin-test.cc@1605 PS6, Line 1605: ASSERT_TRUE(!peer.attrs().replace()); : ASSERT_TRUE(!peer.attrs().promote()); > ASSERT_FALSE() wouldn't be more idiomatic? Done http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/tool_action_tablet.cc@62 PS6, Line 62: using kudu::client::KuduTabletServer; > warning: using decl 'KuduTabletServer' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 23:44:35 +0000 Gerrit-HasComments: Yes
