Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 )
Change subject: [tools] add 'kudu tablet set_attributes' command ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/tool_action_tablet.cc@255 PS6, Line 255: > Nit: maybe say --atribute_promote and --attribute_replace, to draw a more d I think you missed this one. http://gerrit.cloudera.org:8080/#/c/10536/6/src/kudu/tools/tool_action_tablet.cc@353 PS6, Line 353: t's Raft co > Nit: isn't this just a 'command'? Why 'sub-command'? And this one. -- To view, visit http://gerrit.cloudera.org:8080/10536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib304715100ba9062558863f140aa309fd604ace3 Gerrit-Change-Number: 10536 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 00:02:24 +0000 Gerrit-HasComments: Yes
