Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/10/src/kudu/tools/tool_action_hms.cc@394 PS10, Line 394: > Ah, I missed that. However I think this should also cause the tool to fail Done http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@372 PS12, Line 372: 0.$1 in > upgrade Done http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@372 PS12, Line 372: LOG(WARNING) << Substitute("Found legacy table $0.$1 in the Hive Metastore, " > add to the end the exact kudu tool invocation command Done http://gerrit.cloudera.org:8080/#/c/10217/12/src/kudu/tools/tool_action_hms.cc@404 PS12, Line 404: unsynced_tables_map, cout), > This failure should cause the tool to return a non-0 exit status. I imagin Done -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 23 Jun 2018 00:50:40 +0000 Gerrit-HasComments: Yes
