Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10844 )
Change subject: KUDU-2191: Adjust upgrade tool to tolerate downgraded metadata ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10844/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10844/1/src/kudu/tools/tool_action_hms.cc@171 PS1, Line 171: // Only upgrade legacy impala table if the Kudu table with hive-compatible This comment is confusing, because the legacy impala table is upgraded on line 166. Would it be possible to only call the method once by if-gating the AlterKuduTableOnly call? http://gerrit.cloudera.org:8080/#/c/10844/1/src/kudu/tools/tool_action_hms.cc@171 PS1, Line 171: impala table if the Kudu table with hive uppercase Impala and Hive -- To view, visit http://gerrit.cloudera.org:8080/10844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a3b154e77db4eda72b9c4b53861f9fe06f09a3 Gerrit-Change-Number: 10844 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 29 Jun 2018 21:50:18 +0000 Gerrit-HasComments: Yes
