Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10844 )
Change subject: KUDU-2191: Adjust upgrade tool to tolerate downgraded metadata ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc@163 PS2, Line 163: In this case, we only upgrade the legacy Impala table. IIUC the previous statement is unconditionally renaming the kudu table, should the rename be behind a table_name != new_table_name check? http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc@169 PS2, Line 169: s.ok() || table_name == new_table_name What if s is a network error or something else? I don't think you'd want to edit the HMS in that case. -- To view, visit http://gerrit.cloudera.org:8080/10844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a3b154e77db4eda72b9c4b53861f9fe06f09a3 Gerrit-Change-Number: 10844 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 30 Jun 2018 00:10:51 +0000 Gerrit-HasComments: Yes
