Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10844 )
Change subject: KUDU-2191: Adjust upgrade tool to tolerate downgraded metadata ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10844/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10844/4//COMMIT_MSG@9 PS4, Line 9: TestHmsDowngrade keeps on failing as the metadata > Have you looped the updated test via dist-test? I didn't because I think this is a broken test but rather a flaky test. But did one with the latest patch: http://dist-test.cloudera.org/job?job_id=hao.hao.1530566672.124129. TestHmsDowngrade passed 500 out of 500. http://gerrit.cloudera.org:8080/#/c/10844/4//COMMIT_MSG@10 PS4, Line 10: This issue : didn't surface because commit 214dbc249 didn't rebase. This commit : corrects the upgrade tool to better handle this scenario. > To clarify, this means there's some logic in some other commit that was inc Yeah, 214dbc249 didn't rebase with latest change (which includes the change in commit 985c6698a) before push so this issue didn't pop up. http://gerrit.cloudera.org:8080/#/c/10844/4/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10844/4/src/kudu/tools/tool_action_hms.cc@170 PS4, Line 170: : } : if (s.ok()) { : s = hms_catalog->UpgradeLegacyImpalaTable( > Do you think this message would be helpful to append to add to the Status i Done http://gerrit.cloudera.org:8080/#/c/10844/4/src/kudu/tools/tool_action_hms.cc@176 PS4, Line 176: : } : } else { > This usage of AndThen feels a bit weird. Generally, I think of it as chaini Makes sense, will update. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/10844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a3b154e77db4eda72b9c4b53861f9fe06f09a3 Gerrit-Change-Number: 10844 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 02 Jul 2018 21:39:25 +0000 Gerrit-HasComments: Yes
