Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10844 )
Change subject: KUDU-2191: Adjust upgrade tool to tolerate downgraded metadata ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc@163 PS2, Line 163: ew_table_name) { > IIUC the previous statement is unconditionally renaming the kudu table, sho Yeah, I agree. Was trying to reduce the number of the call. But I think as you pointed out, it does not apply here. http://gerrit.cloudera.org:8080/#/c/10844/2/src/kudu/tools/tool_action_hms.cc@169 PS2, Line 169: duTableOnly(kudu_client, table_name, n > What if s is a network error or something else? I don't think you'd want t Done -- To view, visit http://gerrit.cloudera.org:8080/10844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a3b154e77db4eda72b9c4b53861f9fe06f09a3 Gerrit-Change-Number: 10844 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 30 Jun 2018 00:22:46 +0000 Gerrit-HasComments: Yes
