Hello Alexey Serbin, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11083
to review the following change.
Change subject: hms-tool: lookup master addresses config from master
......................................................................
hms-tool: lookup master addresses config from master
The HMS check and fix tools currently use the master addresses
configuration provided on the command line to validate and fix HMS table
metadata. This only works correctly if the administrator inputs the
master addresses exactly as its configured on the masters. If the
hostports are reordered or use a slightly different format which
resolves to the same addresses, then metadata will be flagged as stale
and rewritten unnecessisarily.
This commit changes the handling so that the tools use the master
addresses returned from the ConnectToCluster mechanism already present
in the client, so that the master addresses config will match the
masters.
Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_hms.cc
6 files changed, 55 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11083/1
--
To view, visit http://gerrit.cloudera.org:8080/11083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
