Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14 PS3, Line 14: then metadata will be flagged as stale : and rewritten unnecessarily. For my own edification, what metadata is being referred to here? Kudu metadata? Something in the HMS? You needn't elaborate in the commit message itself; I'm sure this is just context that I lack since I haven't been reviewing all of the HMS work. http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h@194 PS3, Line 194: // Returns the master RPC host ports as configured on the most recently : // connected to leader master. Nit: I'd actually prefer this comment on master_hostports_ because this is clearly a simple accessor; commenting on how the state itself mutates is more useful. -- To view, visit http://gerrit.cloudera.org:8080/11083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec Gerrit-Change-Number: 11083 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 30 Jul 2018 23:50:29 +0000 Gerrit-HasComments: Yes
