Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14 PS3, Line 14: then metadata will be flagged as stale : and rewritten unnecessarily. > For my own edification, what metadata is being referred to here? Kudu metad Yep, sorry this is referring to metadata stored in a Kudu table entry in the HMS. Will update message. http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/11083/3/src/kudu/client/client-internal.h@194 PS3, Line 194: const std::vector<HostPort>& master_hostports() const; : > Nit: I'd actually prefer this comment on master_hostports_ because this is Done -- To view, visit http://gerrit.cloudera.org:8080/11083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec Gerrit-Change-Number: 11083 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 31 Jul 2018 00:06:35 +0000 Gerrit-HasComments: Yes
