Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11260 )
Change subject: KUDU-2531: (part 2) Add -nobackup flag to pbc edit tool ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc@845 PS1, Line 845: return RunTool(Substitute("pbc edit --nobackup $0/instance", kTestDir), > Done What about the other half (i.e. that --backup DOES produce a backup file?) http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/kudu-tool-test.cc@863 PS3, Line 863: auto &child Nit: const auto& -- To view, visit http://gerrit.cloudera.org:8080/11260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If544f7682a30933077db0824452639a68507ba40 Gerrit-Change-Number: 11260 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Aug 2018 22:10:17 +0000 Gerrit-HasComments: Yes
