Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11260 )
Change subject: KUDU-2531: (part 2) Add -nobackup flag to pbc edit tool ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11260/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/4/src/kudu/tools/kudu-tool-test.cc@863 PS4, Line 863: // Make no backup file was written. Nit: Make sure http://gerrit.cloudera.org:8080/#/c/11260/4/src/kudu/tools/kudu-tool-test.cc@866 PS4, Line 866: for (const auto &child : children) { Nit: const auto& (Yeah that's what I wrote earlier, but I was trying to draw attention not just to the lack of const, but also the placement of the ampersand next to the word 'auto'). http://gerrit.cloudera.org:8080/#/c/11260/4/src/kudu/tools/kudu-tool-test.cc@877 PS4, Line 877: // Make sure a backup file was written. You could decompose this into a short helper that handles L846-869 too. Something like: Status HasAtLeastOneBackupFile(const string& dir, bool* found) -- To view, visit http://gerrit.cloudera.org:8080/11260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If544f7682a30933077db0824452639a68507ba40 Gerrit-Change-Number: 11260 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 18:53:47 +0000 Gerrit-HasComments: Yes
