Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11260 )
Change subject: KUDU-2531: (part 2) Add -nobackup flag to pbc edit tool ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11260/5/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/5/src/kudu/tools/kudu-tool-test.cc@365 PS5, Line 365: *found = false; > Nit: we try to stick to the calling convention that if a function returns n Done http://gerrit.cloudera.org:8080/#/c/11260/5/src/kudu/tools/kudu-tool-test.cc@877 PS5, Line 877: bool found_backup = false; > No need to initialize this or on L889; HasAtLeastOneBackupFile guarantees t Done -- To view, visit http://gerrit.cloudera.org:8080/11260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If544f7682a30933077db0824452639a68507ba40 Gerrit-Change-Number: 11260 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:57:55 +0000 Gerrit-HasComments: Yes
