Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11260 )
Change subject: KUDU-2531: (part 2) Add -nobackup flag to pbc edit tool ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc@845 PS1, Line 845: setenv("EDITOR", editor_path.c_str(), /* overwrite */1); > What about the other half (i.e. that --backup DOES produce a backup file?) Done http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/kudu-tool-test.cc@863 PS3, Line 863: ke no backu > Nit: const auto& Done http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/kudu-tool-test.cc@864 PS3, Line 864: > nit: kBakInfix In this case I actually want the test to fail if we change that given it's a sort of "public api". http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/11260/3/src/kudu/tools/tool_action_pbc.cc@214 PS3, Line 214: // We successfully wrote the new file. > nit: I think this comment should be split into two and the backup part move Done -- To view, visit http://gerrit.cloudera.org:8080/11260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If544f7682a30933077db0824452639a68507ba40 Gerrit-Change-Number: 11260 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 16:13:09 +0000 Gerrit-HasComments: Yes
