Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11275 )
Change subject: [thirdparty] allow different URL prefix ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh@58 PS1, Line 58: local URL_PREFIX=$3 I don't think it makes sense to parameterize this, because it's probably going to be the same for _all_ dependencies in a given run of download-thirdparty.sh. Instead, I would add indirection to the URL prefixing variables. Maybe something like: 1. Keep CLOUDFRONT_URL_PREFIX as a read-only variable with the URL for Cloudfront-based downloads. 2. Introduce a new URL variable in vars.sh which defaults to CLOUDFRONT_URL_PREFIX. 3. Use this new variable as the download source in download-thirdparty.sh. Then anyone who wants to use a different download source need only override that new URL variable in the environment, or patch vars.sh to set it to some other value. -- To view, visit http://gerrit.cloudera.org:8080/11275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004828785d9b0d484806d743d7a1084a3ffd576b Gerrit-Change-Number: 11275 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:42:57 +0000 Gerrit-HasComments: Yes
