Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11275 )
Change subject: [thirdparty] allow different URL prefix ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh@129 PS1, Line 129: fetch_with_url_and_patch() { > The problem here is fetch_and_patch already has an optional argument for 'C Ah good point. OK, so let's just focus on making fetch_and_patch simpler. Perhaps like this? // Call fetch_with_url_and_patch with the default dependency URL source. fetch_and_patch() { fetch_with_url_and_patch $1 $2 $3 $DEP_URL "$@" } (I still think CLOUDFRONT_URL_PREFIX should be read-only and there should be a new variable to represent the URL that defaults to CLOUDFRONT_URL_PREFIX but may be overridden/patched). -- To view, visit http://gerrit.cloudera.org:8080/11275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004828785d9b0d484806d743d7a1084a3ffd576b Gerrit-Change-Number: 11275 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 21 Aug 2018 04:14:24 +0000 Gerrit-HasComments: Yes
