Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11275 )
Change subject: [thirdparty] allow different URL prefix ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh@58 PS1, Line 58: local URL_PREFIX=$3 > I don't think it makes sense to parameterize this, because it's probably go I misunderstood Hao's use case: she does want to download some dependencies from an alternative URL, and the rest from the usual Cloudfront URL. So parameterization is necessary. http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh@129 PS1, Line 129: fetch_with_url_and_patch() { Could we avoid needing both fetch_with_url_and_patch and fetch_and_patch by adding URL_PREFIX as the (optional) last argument to fetch_and_patch? With a good comment I think it'll be pretty obvious how one should use the function. -- To view, visit http://gerrit.cloudera.org:8080/11275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004828785d9b0d484806d743d7a1084a3ffd576b Gerrit-Change-Number: 11275 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 22:04:58 +0000 Gerrit-HasComments: Yes
