Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11275 )
Change subject: [thirdparty] allow different URL prefix ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/11275/1/thirdparty/download-thirdparty.sh@129 PS1, Line 129: > Ah good point. OK, so let's just focus on making fetch_and_patch simpler. P Thanks for the suggestion. Updated, but I don't think the above line will work without shift the arguments, as '$@' means all of the parameters passed to the function. -- To view, visit http://gerrit.cloudera.org:8080/11275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004828785d9b0d484806d743d7a1084a3ffd576b Gerrit-Change-Number: 11275 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 22 Aug 2018 00:12:29 +0000 Gerrit-HasComments: Yes
