Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc File src/kudu/util/sanitizer_options.cc: http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc@42 PS10, Line 42: #if defined(KUDU_EXTERNAL_SYMBOLIZER_PATH) > I will move it. I think it's valid an potentially useful to allow KUDU_EXTERNAL_SYMBOLIZER_PATH to be unset. I used it while testing CMake file changes and overrides. Given our build reliably defines it I don't think we need to make it an error. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 17:58:55 +0000 Gerrit-HasComments: Yes
