Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc File src/kudu/util/sanitizer_options.cc: http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc@35 PS10, Line 35: // A macro to turn a symbol into a string. : #define AS_STRING(x) AS_STRING_INTERNAL(x) : #define AS_STRING_INTERNAL(x) #x Can't you just include gutil/macros.h and use that? http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc@42 PS10, Line 42: #if defined(KUDU_EXTERNAL_SYMBOLIZER_PATH) Perhaps we should #error if this isn't defined? Do we really want to allow that case? Also, where are we setting this? I expected an add_compile_definitions() or something equivalent in util/CMakeLists.txt. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 17:34:13 +0000 Gerrit-HasComments: Yes
