Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/11176/11/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11176/11/src/kudu/util/CMakeLists.txt@282 PS11, Line 282: add_library(kudu_sanitizer_options STATIC sanitizer_options.cc) Nit: could call this target just 'sanitizer_options'; we generally prefix with kudu only when the rest of the target name is vague. http://gerrit.cloudera.org:8080/#/c/11176/11/src/kudu/util/CMakeLists.txt@283 PS11, Line 283: target_link_libraries(gutil) This should be: target_link_libraries(kudu_sanitizer_options, gutil) http://gerrit.cloudera.org:8080/#/c/11176/11/src/kudu/util/CMakeLists.txt@291 PS11, Line 291: target_compile_definitions(kudu_sanitizer_options KUDU_EXTERNAL_SYMBOLIZER_PATH=${KUDU_LLVM_SYMBOLIZER_PATH}) I think this needs the keyword PRIVATE (after the target name) so that the compile definitions don't make it to other dependent targets. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 18:48:50 +0000 Gerrit-HasComments: Yes
