Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/11176/8/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11176/8/CMakeLists.txt@1279 PS8, Line 1279: > extra space here Missed this. http://gerrit.cloudera.org:8080/#/c/11176/8/CMakeLists.txt@1280 PS8, Line 1280: coulbe > could be And this. http://gerrit.cloudera.org:8080/#/c/11176/9/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11176/9/CMakeLists.txt@1281 PS9, Line 1281: kudu_test_main kudu_test_util Do we still need these two in the list now that we have our fancy macro? http://gerrit.cloudera.org:8080/#/c/11176/9/CMakeLists.txt@1284 PS9, Line 1284: SET_KUDU_TEST_LINK_LIBS You mean KUDU_TEST_LINK_LIBS here. http://gerrit.cloudera.org:8080/#/c/11176/9/CMakeLists.txt@1291 PS9, Line 1291: set(KUDU_TEST_LINK_LIBS ${KUDU_TEST_LINK_LIBS} ${ARG}) Have you looked into cmake's list() functions? They may simplify this a bit: https://cmake.org/cmake/help/latest/command/list.html#append http://gerrit.cloudera.org:8080/#/c/11176/9/src/kudu/benchmarks/CMakeLists.txt File src/kudu/benchmarks/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11176/9/src/kudu/benchmarks/CMakeLists.txt@59 PS9, Line 59: set(KUDU_TEST_LINK_LIBS ${KUDU_TEST_LINK_LIBS} tpch) Not using the macro here? -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 9 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 16:25:18 +0000 Gerrit-HasComments: Yes
