Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 )
Change subject: [tools] ksck checksums: Add KsckChecksummer class ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.h File src/kudu/tools/ksck_checksum.h: http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.h@193 PS1, Line 193: Status ChecksumData(const KsckChecksumOptions& opts, > warning: function 'kudu::tools::KsckChecksummer::ChecksumData' has a defini Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@87 PS1, Line 87: const vector<string>& table_filters, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@88 PS1, Line 88: const vector<string>& tablet_id_filters) > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@261 PS1, Line 261: shared_ptr<KsckTabletServer> ts = FindOrDie(cluster.tablet_servers(), > warning: the variable 'ts' is copy-constructed from a const reference but i Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@282 PS1, Line 282: std::move(replica_checksum)); > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@286 PS1, Line 286: std::move(tablet_checksum)); > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/11498/1/src/kudu/tools/ksck_checksum.cc@289 PS1, Line 289: InsertOrDie(table_checksum_map, table->name(), std::move(table_checksum)); > warning: passing result of std::move() as a const reference argument; no mo Done -- To view, visit http://gerrit.cloudera.org:8080/11498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2016936eaa26fd6b499783e7d5d8f404816b37fa Gerrit-Change-Number: 11498 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 24 Sep 2018 15:15:11 +0000 Gerrit-HasComments: Yes
