Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 )
Change subject: [tools] ksck checksums: Add KsckChecksummer class ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck.cc@a637 PS2, Line 637: nit: Maybe keep this around as a note? It's probably not too difficult to reason about why we don't want to print progress updates if we're printing JSON, but I think calling it out explicitly is still helpful. http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck.cc@425 PS2, Line 425: table_filters_for_checksum_opts, : tablet_id_filters_for_checksum_opts We should std::move these http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck_checksum.cc@188 PS2, Line 188: const KsckCluster& cluster, `cluster_` is already a private member. What's the thought process behind making `BuildTabletTableMap()` and `CollateChecksumResults()` static? http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck_checksum.cc@345 PS2, Line 345: timestamp of the : // some nit: extra word -- To view, visit http://gerrit.cloudera.org:8080/11498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2016936eaa26fd6b499783e7d5d8f404816b37fa Gerrit-Change-Number: 11498 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 15:33:29 +0000 Gerrit-HasComments: Yes
