Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 )
Change subject: [tools] ksck checksums: Add KsckChecksummer class ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11498/4/src/kudu/tools/ksck_checksum.h File src/kudu/tools/ksck_checksum.h: http://gerrit.cloudera.org:8080/#/c/11498/4/src/kudu/tools/ksck_checksum.h@189 PS4, Line 189: ~KsckChecksummer() = default; Is this needed? http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11498/2/src/kudu/tools/ksck_checksum.cc@188 PS2, Line 188: : cluster_(CHECK_NOTNULL(cl > I feel like making the method static means how it affects state is more exp I think it makes sense to be const: it doesn't affect the state of an instance. But in this case, it _does_ involve the state of the instance via `cluster_`, doesn't it? And to take it a step farther, `opts` could be a const member of the KsckChecksummer too, rather than passing (supposedly) the same `opts` to each method. -- To view, visit http://gerrit.cloudera.org:8080/11498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2016936eaa26fd6b499783e7d5d8f404816b37fa Gerrit-Change-Number: 11498 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 22:07:30 +0000 Gerrit-HasComments: Yes
