Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@430 PS8, Line 430: const string kLocationCmdPath = JoinPathSegments(GetTestExecutableDirectory(), : "testdata/first_argument.sh"); : const string location = "/foo"; nit: use consistent naming schemes for these two variables -- either { location_cmd_path, location } or { kLocationCmdPath, kLocation }. http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@435 PS8, Line 435: mini_cluster_->AddTabletServer() Wrap this call into ASSERT_OK(). http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@448 PS8, Line 448: 3 If you are using this as a hard-coded constant, please then add additional assert somewhere after adding an extra tablet server: ASSERT_EQ(4, cluster_->num_tablet_servers()); http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@450 PS8, Line 450: err_stream_.str() Why not to use err_string here instead? http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@457 PS8, Line 457: err_stream_.str() Why not to use err_string here instead? -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 21:00:06 +0000 Gerrit-HasComments: Yes
