Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 8: > > This patch should be depended on https://gerrit.cloudera.org/#/c/11679/. > > After that patch is reviewed and merged, I will remove some of > the > > duplicate code that should not belong to here and address the > > remaining nits. > > You could just rebase this patch on top of > https://gerrit.cloudera.org/#/c/11679/ > -- that will automatically remove the duplication. I think at first you could rebase this patch on top of current main trunk. That would help to rebase on top of https://gerrit.cloudera.org/#/c/11679/ as next step. -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 15 Oct 2018 18:54:56 +0000 Gerrit-HasComments: No
