Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/client/client.cc@574 PS8, Line 574: "" > I'm not sure passing an empty string as the location is the right way to do My concern is that there are half-baked entities of KuduTabletServer because of this lack of information on location. Generally, having those around might bite us later on when somebody writes the code that uses those instances relying on consistent information on location in KuduTabletServer::Data. I don't have a solution to solve this right away, but I'll think about this a bit. -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 8 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 21:03:21 +0000 Gerrit-HasComments: Yes
