Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@430 PS8, Line 430: // this sometimes won't happen in builds that are slower, so we'll just : // disable the test for those builds. : #if defined(THREAD_SANITIZER) | > nit: use consistent naming schemes for these two variables -- either { loca Done http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@435 PS8, Line 435: #endif > Wrap this call into ASSERT_OK(). Done http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@448 PS8, Line 448: t > If you are using this as a hard-coded constant, please then add additional Done http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@450 PS8, Line 450: > Why not to use err_string here instead? Done http://gerrit.cloudera.org:8080/#/c/11422/8/src/kudu/tools/ksck_remote-test.cc@457 PS8, Line 457: > Why not to use err_string here instead? Done -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 9 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 15 Oct 2018 22:25:12 +0000 Gerrit-HasComments: Yes
