Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11656 )
Change subject: [sentry] SentryAction ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc File src/kudu/sentry/sentry_action-test.cc: http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc@69 PS3, Line 69: for (const auto& action : actions) { nit: these couple loops could be coalesced into one loop, along with the "any action implies itself" check at L49 http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc@95 PS3, Line 95: SentryAction invalid_action; It's probably worth ironing out the Imply() behavior when `action_` isn't set. I think right now this would lead to undefined behavior, but it should probably result in some InvalidArgument or something, or throw a DCHECK to avoid programmer error http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action.cc File src/kudu/sentry/sentry_action.cc: http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action.cc@74 PS3, Line 74: bool SentryAction::Imply(SentryAction other) { const ref -- To view, visit http://gerrit.cloudera.org:8080/11656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e60b79a60fd791ec966f6271c676323bf74d49 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sun, 14 Oct 2018 02:55:21 +0000 Gerrit-HasComments: Yes
