Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11656 )
Change subject: [sentry] SentryAction ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc File src/kudu/sentry/sentry_action-test.cc: http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc@69 PS3, Line 69: ASSERT_TRUE(owner.Imply(*action)); > nit: these couple loops could be coalesced into one loop, along with the "a Done http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc@95 PS3, Line 95: ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); > It's probably worth ironing out the Imply() behavior when `action_` isn't s Thanks for capturing this. Removed the default constructor to avoid undefined behavior. http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action.cc File src/kudu/sentry/sentry_action.cc: http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action.cc@74 PS3, Line 74: action() == Action::OWNER) { > const ref Done -- To view, visit http://gerrit.cloudera.org:8080/11656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e60b79a60fd791ec966f6271c676323bf74d49 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 15 Oct 2018 03:30:43 +0000 Gerrit-HasComments: Yes
