Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11656 )
Change subject: [sentry] SentryAction ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc File src/kudu/sentry/sentry_action-test.cc: http://gerrit.cloudera.org:8080/#/c/11656/3/src/kudu/sentry/sentry_action-test.cc@95 PS3, Line 95: ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); > Thanks for capturing this. Removed the default constructor to avoid undefin By default, default constructor is just empty, so the UB is still the same without explicitly declaring the default constructor. To avoid it, perhaps add an UNINITIALIZED or INVALID SentryAction enum and have it be initialized to that in the default constructor. See "Implicitly-defined default constructor" here: https://en.cppreference.com/w/cpp/language/default_constructor -- To view, visit http://gerrit.cloudera.org:8080/11656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e60b79a60fd791ec966f6271c676323bf74d49 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 15 Oct 2018 17:53:04 +0000 Gerrit-HasComments: Yes
