Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11656 )
Change subject: [sentry] SentryAction ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action-test.cc File src/kudu/sentry/sentry_action-test.cc: http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action-test.cc@53 PS5, Line 53: > This would be simpler as a vector<SentryAction>, since it could use an inti Done http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action.h File src/kudu/sentry/sentry_action.h: http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action.h@76 PS5, Line 76: bool Imply(const SentryAction& other) const; > Can this be const? Done http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action.cc File src/kudu/sentry/sentry_action.cc: http://gerrit.cloudera.org:8080/#/c/11656/5/src/kudu/sentry/sentry_action.cc@77 PS5, Line 77: // Any action must be initialized. > Maybe this should CHECK fail? It should be a bug if an uninitialized actio Done -- To view, visit http://gerrit.cloudera.org:8080/11656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e60b79a60fd791ec966f6271c676323bf74d49 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 16 Oct 2018 00:33:46 +0000 Gerrit-HasComments: Yes
