Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )
Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle File java/kudu-protocol/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18 PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle" What's the purpose of this new module? http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@35 PS2, Line 35: protcol protocol http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@22 PS2, Line 22: whitespace http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26 PS2, Line 26: compileUnshaded libs.log4j Shouldn't this and slf4jLog4j12 be test scoped dependencies? I imagine people are going to use this module as a library, right? http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@34 PS2, Line 34: // kudu-test-utils has no public Javadoc. Seems like it should? http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java@179 PS2, Line 179: throw new IOException(resp.getError().getMessage()); This should probably be RuntimeException, this is an error happening on the server side which has been successfully transmitted back. Are Status.fromPB and NonREcoverableException ctor's private? -- To view, visit http://gerrit.cloudera.org:8080/11686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9 Gerrit-Change-Number: 11686 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 15 Oct 2018 21:42:59 +0000 Gerrit-HasComments: Yes
