Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )
Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle File java/kudu-protocol/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18 PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle" > Breaking out the protocol build is a bit of a side task now. It was Does it result in an additional JAR that needs to be published and transitively depended on by the other modules? http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26 PS2, Line 26: > CapturingLogAppender depends on some log4j specific things. I will see what ah OK, I wouldn't worry about it then -- To view, visit http://gerrit.cloudera.org:8080/11686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9 Gerrit-Change-Number: 11686 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Oct 2018 00:32:38 +0000 Gerrit-HasComments: Yes
