Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )
Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26 PS2, Line 26: compileUnshaded libs.log4j > Shouldn't this and slf4jLog4j12 be test scoped dependencies? I imagine peo CapturingLogAppender depends on some log4j specific things. I will see what I can do to remove these. -- To view, visit http://gerrit.cloudera.org:8080/11686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9 Gerrit-Change-Number: 11686 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 16 Oct 2018 14:38:37 +0000 Gerrit-HasComments: Yes
