Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11686 )
Change subject: KUDU-2411: (Part 1) Break out existing test utilities into a seperate module ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle File java/kudu-protocol/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-protocol/build.gradle@18 PS2, Line 18: apply from: "$rootDir/gradle/protobuf.gradle" > Does it result in an additional JAR that needs to be published and transiti It is another jar published but it is shaded by the client and doesn't have any transitive impact. http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/11686/2/java/kudu-test-utils/build.gradle@26 PS2, Line 26: compileUnshaded libs.log4j > CapturingLogAppender depends on some log4j specific things. I will see what I marked these dependencies as optional so they won't be pulled in by default, but need to exist if CapturingLogAppender is used. -- To view, visit http://gerrit.cloudera.org:8080/11686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa935d6038b6d8756b332178347cec5cb70660a9 Gerrit-Change-Number: 11686 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Oct 2018 02:24:40 +0000 Gerrit-HasComments: Yes
