Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/11735/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11735/6//COMMIT_MSG@21 PS6, Line 21: kudu/version.py > Should be kudu/version.py I can't find kudu_version.py nor version.py anywhere in master or this branch, am I missing something? http://gerrit.cloudera.org:8080/#/c/11735/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11735/7//COMMIT_MSG@22 PS7, Line 22: … nit: it seems your text editor replaced "..." (0x2e 0x2e 0x2e) with the "ellipsis" Unicode character (U+2026). I don't think this would break any tool, but it would still be better to stick to ASCII. -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:55:26 +0000 Gerrit-HasComments: Yes
