Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py@55 PS6, Line 55: version += '.dev0' > AFAICT the old code was actually buggy in that even though it appended ".de We weren't, my commit message addresses this. If you use dev it prints a warning and auto normalizes it to dev0 anyway. http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py@59 PS6, Line 59: is_release = "dev" not in version > Maybe constrain this to a ".dev" suffix? I wanted to support dev0, dev1, etc. This seams good enough given setting dev is contained within this script. -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:32:27 +0000 Gerrit-HasComments: Yes
