Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11735/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11735/6//COMMIT_MSG@21 PS6, Line 21: kudu_version.py Should be kudu/version.py http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py@55 PS6, Line 55: version += '.dev0' > We weren't, my commit message addresses this. Oh right, I had read your commit message as saying that you've corrected _this patch_ to properly append ".dev0" rather than _the code_. So you were aware of this, OK. -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:35:18 +0000 Gerrit-HasComments: Yes
