Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py@55 PS6, Line 55: version += '.dev0' AFAICT the old code was actually buggy in that even though it appended ".dev" to the local variable version, when it substituted the actual version in, it used the global variable VERSION rather than the local version. So I don't know if we were ever actually appending ".dev". Also, why ".dev0" and not ".dev"? http://gerrit.cloudera.org:8080/#/c/11735/6/python/setup.py@59 PS6, Line 59: is_release = "dev" not in version Maybe constrain this to a ".dev" suffix? -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:30:08 +0000 Gerrit-HasComments: Yes
