Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: [location_awareness] Add ts location to both client and internal client ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: [location_awareness] Add ts location to both client and internal client > I'm not sure if I understand. We make it a private API so that the client c As-is, even though you've added a new accessor with public visibility to client.h, the C++ public client API surface has not changed, because the accessor is annotated with KUDU_NO_EXPORT, which means third party applications can't call it. So what's the broader context here? How will this patch be used? -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 18 Oct 2018 22:29:06 +0000 Gerrit-HasComments: Yes
