Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 )
Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc@1378 PS1, Line 1378: take its compact_flush_lock Wait, but those compact_flush_locks are taken and released one by one by this code, right? How could it happen that one thread takes and holds more than 64 of those? http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc@1385 PS1, Line 1385: #if defined(THREAD_SANITIZER) style nit: there is an alternative style for those ifdefs, if you want: # if defined(...) const auto kMaxPickedUnderTsan = 32; # endif http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc@1386 PS1, Line 1386: const nit: constexpr ? -- To view, visit http://gerrit.cloudera.org:8080/11885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ad4ba3a13995c194c3308d72c1eb9b611ef766 Gerrit-Change-Number: 11885 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 06 Nov 2018 06:13:30 +0000 Gerrit-HasComments: Yes
