Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 )
Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode ...................................................................... Patch Set 2: > > Where did that 256KB figure come from? Can you point me at it? > > I'm spending some time digging into the iterators underneath > compaction to see if I can find it :). Right now it's just what > Todd said. > > There is a 32KiB arena on the top of all the iterators for > compactions. See compaction.cc L205. Do I understand correctly that limiting number of rowsets for compaction in general case (i.e. what Todd suggested) will be published as a separate changelist? -- To view, visit http://gerrit.cloudera.org:8080/11885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ad4ba3a13995c194c3308d72c1eb9b611ef766 Gerrit-Change-Number: 11885 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 07 Nov 2018 00:25:31 +0000 Gerrit-HasComments: No
