Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11885
to look at the new patch set (#2).
Change subject: Limit number of rowsets in compaction selection to 32 in TSAN
mode
......................................................................
Limit number of rowsets in compaction selection to 32 in TSAN mode
TSAN limits the number of simultaneous lock acquisitions in a single
thread to 64 when using the deadlock detector[1]. However, compaction
can select up to 128 (128MB budget / 1MB min rowset size) rowsets in a
single op. kudu-tool-test's TestNonRandomWorkloadLoadgen almost always
hits TSAN's limit when the KUDU-1400 changes following this patch are
applied. This patch prevents this by limiting the number of rowsets
selected for a compaction to 32 when running under TSAN.
I ran the test with the KUDU-1400 changes on top and saw 97/100
failures. With the change, I saw 100 successes.
[1]: https://github.com/google/sanitizers/issues/950
Change-Id: I01ad4ba3a13995c194c3308d72c1eb9b611ef766
---
M src/kudu/tablet/tablet.cc
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/11885/2
--
To view, visit http://gerrit.cloudera.org:8080/11885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ad4ba3a13995c194c3308d72c1eb9b611ef766
Gerrit-Change-Number: 11885
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <[email protected]>
