Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 )
Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc@1378 PS1, Line 1378: take its compact_flush_lock > Wait, but those compact_flush_locks are taken and released one by one by th See L1407 below. The lock is moved into the 'picked' collection. http://gerrit.cloudera.org:8080/#/c/11885/1/src/kudu/tablet/tablet.cc@1385 PS1, Line 1385: #if defined(THREAD_SANITIZER) > style nit: there is an alternative style for those ifdefs, if you want: This is an alternative way to do indentation? I'm not understanding what the point of the difference is. -- To view, visit http://gerrit.cloudera.org:8080/11885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ad4ba3a13995c194c3308d72c1eb9b611ef766 Gerrit-Change-Number: 11885 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 06:19:29 +0000 Gerrit-HasComments: Yes
