Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect to cluster ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc@537 PS5, Line 537: Status s = TSDescriptor::RegisterNew(instance, registration, &desc); This seems like the most significant aspect of the change, and should be pulled out into its own commit so it can be properly discussed. What's the motivation for treating the client as a tserver and "registering" it with the master vs. refactoring the location-assigning machinery so that clients can use it without registering? -- To view, visit http://gerrit.cloudera.org:8080/11923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a Gerrit-Change-Number: 11923 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 19:14:27 +0000 Gerrit-HasComments: Yes
