Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect to cluster ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc@537 PS5, Line 537: Status s = TSDescriptor::RegisterNew(instance, registration, &desc); > As far as I remember, the idea was to assign location for the client based I've been trying to write a separate function to do the client location assignment. But there are dependencies (the defn of location_mapping_cmd, GetLocationFromLocationMappingCmd helper function, etc..) all in the ts_descriptor. I'm thinking maybe move these common parts that do location assignment in a new file so that the master_service can be depended on the new file without depending on the ts_descriptor. Does that sound reasonable? -- To view, visit http://gerrit.cloudera.org:8080/11923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a Gerrit-Change-Number: 11923 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:49:03 +0000 Gerrit-HasComments: Yes
