Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect to cluster ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master.proto@677 PS5, Line 677: optional string client_location = 7; nit: add a comment describing what client location is http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master_service.cc@537 PS5, Line 537: Status s = TSDescriptor::RegisterNew(instance, registration, &desc); > I see. I thought the client should also get location assigned through regis As far as I remember, the idea was to assign location for the client based on its IP address using the location assignment script. However, tserver registration is not relevant here. Basically, the tserver registration code is very specific for registering tablet servers, not assigning location to a client. In general, I think here we need to pass information on client IP address to the location assignment script and get the result, but that should not go through TSDescriptor-related code path since it has too much of tserver-related specifics. -- To view, visit http://gerrit.cloudera.org:8080/11923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a Gerrit-Change-Number: 11923 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 21:35:55 +0000 Gerrit-HasComments: Yes
